-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-6931] - Fixed top spacing for NodeBalancer empty state #9746
fix: [M3-6931] - Fixed top spacing for NodeBalancer empty state #9746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @tyler-akamai!
Not to suggest increasing the scope of this work, but is there a technical reason why this is the only empty landing page that doesn't use the <ResourcesSection />
component?
Yeah I started to look into it but found that I needed to collect the different links from the documentation and ui team, and it seemed outside of the scope for this ticket. But I can create a new ticket to migrate the NodeBalancer empty state to |
Makes sense! A separate ticket sounds good to me. Thanks again @tyler-akamai! |
@jdamore-linode I think this is because the ++ to @tyler-akamai for a separate ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! confirming NodeBalancer top spacing is consistent with other landing pages Volumes, kubernetes and Domains
Looks better but I wonder if it makes sense to go ahead and refactor this to use Edit: Oops, just read the other comments! Carry on 🫣 |
Description 📝
Fixed the top spacing for the NodeBalancer empty state
Major Changes 🔄
Preview 📷
Before
After
How to test 🧪